Skip to content

[pull] main from MetaMask:main#666

Merged
pull[bot] merged 2 commits into
Reality2byte:mainfrom
MetaMask:main
Jun 19, 2026
Merged

[pull] main from MetaMask:main#666
pull[bot] merged 2 commits into
Reality2byte:mainfrom
MetaMask:main

Conversation

@pull

@pull pull Bot commented Jun 19, 2026

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

ieow and others added 2 commits June 19, 2026 06:24
## Explanation

Follow-up to #8933. The `does not mutate DEFAULT_AGENTIC_CLI_PREFERENCES
when coercing legacy payloads` test in
`@metamask/authenticated-user-storage` failed TypeScript and ESLint
checks after `agenticCli` was added as an optional field on
`NotificationPreferences`.

The guard now checks `result?.agenticCli` instead of only `result`, so
TypeScript narrows correctly before the test mutates
`result.agenticCli.inAppNotificationsEnabled`. No runtime or API
behavior changes.

## References

* Follow-up to #8933

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them
## Explanation

**Current state:** `@metamask/ramps-controller@14.2.0` is the latest
publish on npm. Since then, two consumer-facing changes merged to `main`
but are not yet published:

- **#9159 (TRAM-3539)** — `RampsController` now merges orders on the
internal MetaMask order code (from canonical `order.id`, e.g.
`c-{guid}`) instead of `providerOrderId`. Without this, Moonpay redirect
buys can produce duplicate Activity rows (precreate stub + provider
callback row).
- **#9135** — exports `getTransakApiMessage`,
`isTransakPhoneRegisteredError`, and centralized Transak API error codes
for client-side error handling.

Mobile QA is currently blocked on a **preview build**
(`@metamask-previews/ramps-controller`) for TestFlight; we need a real
npm release to drop preview/resolution pins.

**Solution:** Release **1055.0.0** publishes
**`@metamask/ramps-controller@14.3.0`**. This PR only versions and ships
what is already on `main` — no new feature work in the diff.

**What's in 14.3.0:**

| Category | Change |
|----------|--------|
| **Fixed** | Compare internal order codes in `addOrder` / `getOrder` /
`addPrecreatedOrder`
([#9159](#9159)) |
| **Added** | Transak API error helpers (`getTransakApiMessage`,
`isTransakPhoneRegisteredError`, `transakErrorCodes.ts`)
([#9135](#9135)) |
| **Changed** | Bump `@metamask/profile-sync-controller` to `^28.2.0`
([#9119](#9119)) |

**SemVer:** Minor bump (14.2.0 → 14.3.0) — includes new exports plus a
bug fix. No breaking API changes.

**Other packages / deps:** Only `@metamask/ramps-controller` is
published in this release. Dependency bumps listed above were already
merged separately and are included because they landed after 14.2.0.

**Worth noting for reviewers:** The fix normalizes stored
`providerOrderId` to the internal order code for polling/lookup
consistency. Order Details “copy id” may show the MetaMask `c-…` code
rather than the provider-native UUID — support should use provider link
/ tx hash for native references.

## References

- TRAM-3539 — duplicate Moonpay Activity rows on redirect buys
- [#9159](#9159) — internal order
id merge fix
- [#9135](#9135) — Transak API
error helpers
- [#9119](#9119) —
profile-sync-controller dep bump
-
[MetaMask/metamask-mobile#31837](MetaMask/metamask-mobile#31837)
— mobile QA PR (preview pin; update to `^14.3.0` after this release)

**Mobile follow-up after merge + npm publish:**
1. Bump `@metamask/ramps-controller` to `^14.3.0`
2. Remove preview alias / `resolutions` / `previewBuilds`
3. Re-run TestFlight QA for Moonpay redirect buy (single Activity row)

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them _(N/A — no breaking changes)_

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Release-only version, changelog, and lockfile updates with no runtime
code changes in this diff.
> 
> **Overview**
> Release **1055.0.0** publishes **`@metamask/ramps-controller@14.3.0`**
to npm. The PR diff is versioning and dependency wiring only—no new
feature code.
> 
> **`@metamask/ramps-controller`** goes **14.2.0 → 14.3.0** with
changelog section **14.3.0** (content already on `main`): Transak error
helpers (`getTransakApiMessage`, `isTransakPhoneRegisteredError`,
`transakErrorCodes.ts`), bump to `@metamask/profile-sync-controller`
^28.2.0, and the documented order-id merge fix for duplicate Moonpay
Activity rows.
> 
> Root **`package.json`** is bumped **1054.0.0 → 1055.0.0**.
**`@metamask/transaction-pay-controller`** updates its dependency to
**`@metamask/ramps-controller` ^14.3.0** and records that in its
changelog; **`yarn.lock`** is updated accordingly.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
4685db4. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@pull pull Bot locked and limited conversation to collaborators Jun 19, 2026
@pull pull Bot added the ⤵️ pull label Jun 19, 2026
@pull pull Bot merged commit cfd51af into Reality2byte:main Jun 19, 2026
0 of 4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants